Skip to content

Commit

Permalink
core: exclude CorePlugin from plugins_listing
Browse files Browse the repository at this point in the history
Summary:
The `plugins_listing` response has long included a `"core"` key. Prior
to #2299 and #2304, this did nothing; now, it properly emits a warning,
because the frontend does not know how to render such a plugin. There’s
no reason that the frontend needs to know about this plugin at all.

Test Plan:
Observe that the “Plugin has no loading mechanism and no baked-in
registry entry: core” warning no longer appears in the JS console.

wchargin-branch: core-verb
  • Loading branch information
wchargin committed Jun 4, 2019
1 parent d8d6bb4 commit 60149d2
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tensorboard/backend/application.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,9 @@ def _serve_plugins_listing(self, request):
"""
response = collections.OrderedDict()
for plugin in self._plugins:
if type(plugin) is core_plugin.CorePlugin: # pylint: disable=unidiomatic-typecheck
# This plugin's existence is a backend implementation detail.
continue
start = time.time()
is_active = plugin.is_active()
elapsed = time.time() - start
Expand Down

0 comments on commit 60149d2

Please sign in to comment.