Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

subview op of mixed shape #249

Open
bondhugula opened this issue Nov 20, 2019 · 2 comments
Open

subview op of mixed shape #249

bondhugula opened this issue Nov 20, 2019 · 2 comments

Comments

@bondhugula
Copy link
Contributor

Subview op's with mixed shape (static and dynamic dimensions) currently parse and verify correctly. This is inconsistent given the number of size values that are taken as input. (In the example below, the size of the 2nd dimension of the subview would be undefined -- 8 as per the shape but %arg as per the op that creates the memref).

#map = (d0, d1, d2)[s0, s1, s2] -> (d0 * s2 + d1 * s1 + d2 + s0)

%sv = std.subview %m[%c0, %c0, %c0][%c1, %arg, %c1][%c1, %c1, %c1] : memref<?x8x?xf32> to memref<?x8x?xf32, #map>
@MaheshRavishankar
Copy link
Contributor

Thanks Uday. There is a change to the SubViewOp specification (that should land in github soon). Though that change still missed this case. Will fix this. Thanks!

@MaheshRavishankar
Copy link
Contributor

This should be fixed by 750617c

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants