Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize tests for dataset #651

Closed
yongtang opened this issue Nov 18, 2019 · 2 comments
Closed

Standardize tests for dataset #651

yongtang opened this issue Nov 18, 2019 · 2 comments

Comments

@yongtang
Copy link
Member

We are adding more and more formats to dataset, though the tests are pretty much ad hoc at the moment. Since tf.data's pipeline is pretty standard, we could standardize the tests for almost all Dataset in tensorflow-io by parametrization and fixture. We also need benchmark (with pytest-benchmark?).

/cc @BryanCutler as quite a few columnar dataset are from Arrow, I think it might be easier to standardize tests for those.

The tests for audio and streaming dataset could also be standardized as well.

/cc @terrytangyuan

@BryanCutler
Copy link
Member

Sounds like a really good idea to me!

@yongtang
Copy link
Member Author

Our tests for the majority of the dataset has been standardized in test_io_dataset_eager.py, with different scenarios testing increased functionality. Will continue to enhance the tests, but will close this issue as tests are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants