Skip to content

Check for updates to insecure gems #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petitJAM opened this issue Aug 31, 2018 · 1 comment
Open

Check for updates to insecure gems #42

petitJAM opened this issue Aug 31, 2018 · 1 comment

Comments

@petitJAM
Copy link
Contributor

Sometimes a gem is insecure, but there is no security patch for it yet. This totally breaks our deployments because of scan_gems. There's a work around with I_KNOW_GEMS_ARE_INSECURE, but it's a huge pain.

I propose that the scan_gems task pings rubygems.org to find the latest version of the insecure gem to see if there's an update. If there is no update, it should not stop the deployment process and instead just display a warning. If there is an update, it should abort the deployment as it does now.

The task in question:

@petitJAM
Copy link
Contributor Author

That PR got merged, but I've reverted it before release. The concern is that a gem like omniauth which was insecure with no patch but had mitigations could hide behind this without being noticed.

Slack discussion here:
https://tenforward.slack.com/archives/C02TQ688M/p1613766588144900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant