This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
tendermint-rs: /abci_query RPC endpoint (closes #287) #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
Jul 18, 2019
|
|
||
| /// ABCI Merkle proofs | ||
| #[derive(Clone, Debug, Eq, Hash, PartialEq)] | ||
| pub struct Proof(Vec<u8>); |
There was a problem hiding this comment.
@ebuchman this seems like it might have some overlap with the stuff you're working on? That said, is this an OK start?
tarcieri
commented
Jul 18, 2019
| @@ -9,7 +9,7 @@ use std::{ | |||
| /// Block height for a particular chain (i.e. number of blocks created since | |||
| /// the chain began) | |||
| #[derive(Copy, Clone, Eq, Hash, PartialEq, PartialOrd, Ord)] | |||
| pub struct Height(pub u64); | |||
| pub struct Height(u64); | |||
There was a problem hiding this comment.
With pub on the u64 this wraps, the Height type can't maintain invariants (i.e. >0 or >=0)
tarcieri
force-pushed
the
tendermint-rs/abci_query
branch
from
7491c6f
to
8daaeb0
Compare
Adds support for invoking the ABCIQuery endpoint: https://tendermint.com/rpc/#abciquery
tarcieri
force-pushed
the
tendermint-rs/abci_query
branch
from
8daaeb0
to
1fbbf5e
Compare
tarcieri
commented
Jul 18, 2019
| /// `/abci_query` endpoint | ||
| #[test] | ||
| fn abci_query() { | ||
| // TODO(tarcieri): write integration test for this endpoint |
There was a problem hiding this comment.
Unlike the other endpoints it wasn't clear how to immediately test this in an integration test (with gaiad)
tarcieri
commented
Jul 18, 2019
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Unlike the other JSON examples found in this directory, this one wasn't taken live from a gaiad RPC response, but is copy/paste from https://tendermint.com/rpc/#abciquery
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for invoking the ABCIQuery endpoint:
https://tendermint.com/rpc/#abciquery