gogo/protobuf is unmaintained

[pquerna]

Expected Behavior

github.com/gogo/protobuf is unmaintained: gogo/protobuf#691

At this point it would be nice for the Client SDK to consider using the standard protobuf library.

Actual Behavior

Seems blocked on temporalio/temporal#38

But google.golang.org/protobuf is the defacto dependency at this point, and the client SDK, its unclear if the performance concerns are warranted for general purpose worker clients or other non-temrporal core uses of the APIs?

[cretz]

Yes, there are discussions to be had on whether the performance difference is worth it. I am gathering feedback from others.

[cretz]

Yes, this issue is blocked on temporalio/temporal#38 or similar since we share https://github.com/temporalio/api-go. I will leave this open pending that issue.

[ash2k]

This issue is closed but the gogo dependency is still in the go.mod file. Any chances of getting rid of it completely? Also, would be nice to get a release with the change. Thank you.

[Quinn-With-Two-Ns]

gogoproto is still in the mod file because ProtoJSONPayloadConverter and ProtoPayloadConverter support gogoproto structs and we did not remove support for backwards compatibility

[vikstrous2]

Can you guys find a way to make this dependency optional? How long is this backwards compatibility code needed?

[cretz]

Usually quite a while. But this dependency should be harmless if you don't use it, it's only for people that still use gogoproto in their protos. Can you clarify the issues that this dependency is causing?