From 1a5b8d04435bcdaf9c18e8e89a7f133ea5a5bc68 Mon Sep 17 00:00:00 2001 From: Chris Constable Date: Thu, 30 Apr 2026 10:46:09 -0400 Subject: [PATCH 1/4] ci(test-reports): add test reports to PR checks. this also fixes an issue where test reports were not being uploaded as artifacts. --- .github/workflows/ci.yml | 14 ++++++++------ .github/workflows/test-report.yml | 25 +++++++++++++++++++++++++ 2 files changed, 33 insertions(+), 6 deletions(-) create mode 100644 .github/workflows/test-report.yml diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index a4d2f68e..02855261 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -88,14 +88,16 @@ jobs: run: dotnet build - name: Test - run: dotnet test --logger "console;verbosity=detailed" --blame-crash -v n --blame-hang-timeout 10m + run: | + dotnet test --logger "console;verbosity=detailed" --logger "trx;LogFilePrefix=test-results" --results-directory tests/Temporalio.Tests/TestResults --blame-crash -v m --blame-hang-timeout 10m - - name: Upload test failure - if: ${{ failure() }} - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 + - name: Upload test results + if: ${{ always() }} + uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7 with: - name: test-fail-${{ matrix.os }} - path: tests/Temporalio.Tests/TestResults + name: test-results-${{ matrix.os }} + path: tests/Temporalio.Tests/TestResults/**/*.trx + if-no-files-found: warn - name: Confirm bench works run: dotnet run --project tests/Temporalio.SimpleBench/Temporalio.SimpleBench.csproj -- --workflow-count 5 --max-cached-workflows 100 --max-concurrent 100 diff --git a/.github/workflows/test-report.yml b/.github/workflows/test-report.yml new file mode 100644 index 00000000..ecbb1895 --- /dev/null +++ b/.github/workflows/test-report.yml @@ -0,0 +1,25 @@ +name: Test Report +on: + workflow_run: + workflows: + - Continuous Integration + types: + - completed +permissions: + contents: read + actions: read + checks: write + +jobs: + report: + if: ${{ github.event.workflow_run.event == 'pull_request' && github.event.workflow_run.conclusion != 'cancelled' }} + runs-on: ubuntu-latest + steps: + - name: Test Report + uses: dorny/test-reporter@a43b3a5f7366b97d083190328d2c652e1a8b6aa2 # v3 + with: + artifact: /test-results-(.*)/ + name: Test Results ($1) + path: '**/*.trx' + reporter: dotnet-trx + use-actions-summary: 'false' From d44d5fde5de34967f0e690cde2910a39d2dd06eb Mon Sep 17 00:00:00 2001 From: Christopher Constable Date: Thu, 30 Apr 2026 12:44:15 -0400 Subject: [PATCH 2/4] Update .github/workflows/ci.yml Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 02855261..fecf482a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -92,7 +92,7 @@ jobs: dotnet test --logger "console;verbosity=detailed" --logger "trx;LogFilePrefix=test-results" --results-directory tests/Temporalio.Tests/TestResults --blame-crash -v m --blame-hang-timeout 10m - name: Upload test results - if: ${{ always() }} + if: ${{ !cancelled() }} uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7 with: name: test-results-${{ matrix.os }} From 2bb948c0377f5b204e3d20c600f8ec402d9d2772 Mon Sep 17 00:00:00 2001 From: Christopher Constable Date: Thu, 30 Apr 2026 12:46:31 -0400 Subject: [PATCH 3/4] Bump actions/upload-artifact Co-authored-by: Justin Anderson <44687433+jmaeagle99@users.noreply.github.com> --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index fecf482a..45315cf8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -93,7 +93,7 @@ jobs: - name: Upload test results if: ${{ !cancelled() }} - uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7 + uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7 with: name: test-results-${{ matrix.os }} path: tests/Temporalio.Tests/TestResults/**/*.trx From e1386cc5a51d1af6c95fe73e23fd1adfdf34df97 Mon Sep 17 00:00:00 2001 From: Chris Constable Date: Thu, 30 Apr 2026 12:49:19 -0400 Subject: [PATCH 4/4] switch from minimal -> normal logging --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 45315cf8..19edc0b5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -89,7 +89,7 @@ jobs: - name: Test run: | - dotnet test --logger "console;verbosity=detailed" --logger "trx;LogFilePrefix=test-results" --results-directory tests/Temporalio.Tests/TestResults --blame-crash -v m --blame-hang-timeout 10m + dotnet test --logger "console;verbosity=detailed" --logger "trx;LogFilePrefix=test-results" --results-directory tests/Temporalio.Tests/TestResults --blame-crash -v n --blame-hang-timeout 10m - name: Upload test results if: ${{ !cancelled() }}