Minor update fixes #382
Merged
Minor update fixes #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
reviewed
Dec 19, 2024
| // exception, that will come when _they_ call get result | ||
| var handle = new WorkflowUpdateHandle<TResult>( | ||
| Client, req.Request.Meta.UpdateId, input.Id, input.RunId) | ||
| Client, req.Request.Meta.UpdateId, input.Id, resp.UpdateRef.WorkflowExecution.RunId) |
Contributor
There was a problem hiding this comment.
We should really add a test for this. (I know the other fix is hard to test).
Member
Author
There was a problem hiding this comment.
Added assertion to existing test that would have failed before (basically just ensures run ID now exists, because it was null before)
dandavison
reviewed
Dec 19, 2024
| var grpcStatus = new GrpcStatus() { Code = nonAborted.Code, Message = nonAborted.Message }; | ||
| grpcStatus.Details.AddRange(nonAborted.Details); | ||
| e = new RpcException(grpcStatus); | ||
| var nonAborted = failure.Statuses.FirstOrDefault(s => |
Contributor
There was a problem hiding this comment.
variable name could be failureStatus or something, but not blocking.
dandavison
approved these changes
Dec 19, 2024
Contributor
dandavison
left a comment
dandavison
left a comment
There was a problem hiding this comment.
LGTM. I'm going to try to add a test for the run ID issue in Python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed