Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dev Server concurrent execution test is incorrect and flaky #581

Open
mjameswh opened this issue Jun 4, 2024 · 0 comments
Open

[Bug] Dev Server concurrent execution test is incorrect and flaky #581

mjameswh opened this issue Jun 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mjameswh
Copy link
Contributor

mjameswh commented Jun 4, 2024

Describe the bug

We recently added an integration test that starts a total of 80 dev server, with a maximum of 8 instances running concurrently. This is used to assert, among other things, the reliability of the "get ephemeral port number" logic.

However, that test is incorrect, because it calls FailNow and similar from goroutines, which is not allowed. The test is also flaky. Incorrect usage of test APIs is like not the cause of the flakiness, but may be masking the actual errors, making the issue harder to diagnose.

Given that the CLI's test harness internally use FailNow, fixing this will likely require developing a substitute for the existing test harness.

@mjameswh mjameswh added the bug Something isn't working label Jun 4, 2024
@sync-by-unito sync-by-unito bot closed this as completed Jul 12, 2024
@josh-berry josh-berry reopened this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants