feat!: improve stop points initialization #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leo-desbureaux-tellae
commented
Dec 14, 2023
•
leo-desbureaux-tellae
commented
- new Operator parameter 'stop_points_from': allows providing a way to initialize stop points of the Operator
- changed the init_stops function: now calls a stop point initialisation method depending on the value of the 'stop_points_from' parameter
- added two new methods for stop point initialization:
- initialize stop points from a GeoJSON containing Points. Provide the file name (ending with .geojson) as the 'stop_points_from' parameter. Calls the _stops_table_from_geojson method.
- initialize stop points from GTFS. Provide 'stop_points_from'='gtfs'. Calls the _stops_table_from_gtfs method.
- Other methods can be implemented and called by overriding the init_stops method.
moved "stop_points_from" in Operator's root parameters (from "operation_parameters") options for the "stop_points_from" parameter are a geojson filename and "gtfs". Removed now unused "requests" option. new methods _stops_table_from_geojson and _stops_table_from_gtfs, can be overriden in subclasses to provide a more precise set of stops using operator attributes.
leo-desbureaux-tellae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.