feat!: scenario path management #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
leo-desbureaux-tellae
commented
Jul 28, 2022
•
leo-desbureaux-tellae
commented
- new SimulationScenario class replacing SimulationParameters, manages scenario folders and data
- changed signature of functions to accept a scenario folder path. Scenario path is no longer computed from the model code and scenario name
- BREAKING CHANGE: now provide path to the scenario folder instead of path to the simulation parameters to run a simulation
changed SimulationModel 'parameters' attribute in 'scenario'
…it to starling_sim/
* affected functions: scenario_input_folder, scenario_output_folder, scenario_parameters_filepath, scenario_agent_input_filepath * use os.path.join to create paths
… simulation parameters to run a simulation
leo-desbureaux-tellae
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # elements of the model | ||
| self.agentPopulation = DictPopulation(self.agent_type_class.keys()) | ||
| self.environment = Environment(self.parameters) | ||
| self.environment = Environment(self.scenario) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
|
|
||
| # elements of the model | ||
| self.agentPopulation = DictPopulation(self.agent_type_class.keys()) | ||
| self.environment = Environment(self.parameters) | ||
| self.environment = Environment(self.scenario) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
|
|
||
| # elements of the model | ||
| self.agentPopulation = DictPopulation(self.agent_type_class.keys()) | ||
| self.environment = Environment(self.parameters) | ||
| self.environment = Environment(self.scenario) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.