feat: improve run summary #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the summary added a new method new_output_file to OutputFactory that should be called when output files are generated.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if simulation_model.parameters["traces_output"]: | ||
| try: | ||
| self.generate_trace_output(simulation_model) | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
| if simulation_model.parameters["visualisation_output"]: | ||
| try: | ||
| self.generate_geojson_output(simulation_model) | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
| @@ -150,10 +180,12 @@ | |||
| """ | |||
|
|
|||
| for kpi_output in self.kpi_outputs: | |||
| try: | |||
| kpi_output.write_kpi_table() | |||
| except: | |||
Check notice
Code scanning / CodeQL
Except block handles 'BaseException'
vincent-leblond
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve run summary content and generation
added new contents to the run summary: Starling version and commit, run date, config content, output files and their information
the run summary file is now always generated, removed the 'generate_summary' option in parameters
the run summary file is now named "run_summary.json" instead of "{scenario}_summary.json"
(Close #56)