This repository was archived by the owner on Feb 2, 2021. It is now read-only.
Remove fibers and use async/await #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 |
|
❤️ |
5 similar comments
|
❤️ |
|
❤️ |
|
❤️ |
|
❤️ |
|
❤️ |
|
💔 |
1 similar comment
|
💔 |
|
❤️ |
4 similar comments
|
❤️ |
|
❤️ |
|
❤️ |
|
❤️ |
|
💔 |
TsvetanMilanov
force-pushed
the
all/remove-fibers
branch
from
48e5fe8 to
d3fb2c4
Compare
|
❤️ |
5 similar comments
|
❤️ |
|
❤️ |
|
❤️ |
|
❤️ |
|
❤️ |
rosen-vladimirov
force-pushed
the
all/remove-fibers
branch
from
d3b05fb to
96019e4
Compare
|
❤️ |
1 similar comment
|
❤️ |
|
💔 |
…as we cannot await in function generated from lodash's
TypeScript 2.0 does not add "use strict"; in files which just declare class and does not export it. This breaks Node 4 because of the class keyword.
tslint, grunt-ts and grunt-tslint are updated to latest versions. There are some changes in tslint - no-unreachable, use-strict and no-duplicate-key are removed because these checks are now in the tsc. The no-unused-variable is deprecated because the tsc has noUnusedLocals and noUnusedParameters. In the CLI we need only noUnusedLocals.
TsvetanMilanov
force-pushed
the
all/remove-fibers
branch
from
0d04e57 to
d36d30c
Compare
|
❤️ |
TsvetanMilanov
approved these changes
Jan 13, 2017
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove fibers and use async/await instead.