Use async API from ios-sim

Fixes NativeScript/nativescript-cli#3545

Author: Fatme

appbuilder/providers/device-app-data-provider.ts

@@ -102,7 +102,7 @@ export class IOSAppIdentifier extends AppBuilderDeviceAppDataBase implements ILi
 	@cache()
 	public async getDeviceProjectRootPath(): Promise<string> {
 		if (this.device.isEmulator) {
-			const applicationPath = this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
+			const applicationPath = await this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
 			return path.join(applicationPath, "www");
 		}
 
@@ -127,7 +127,7 @@ export class IOSNativeScriptAppIdentifier extends AppBuilderDeviceAppDataBase im
 	@cache()
 	public async getDeviceProjectRootPath(): Promise<string> {
 		if (this.device.isEmulator) {
-			const applicationPath = this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
+			const applicationPath = await this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
 			return applicationPath;
 		}
 

definitions/mobile.d.ts

@@ -233,7 +233,7 @@ declare module Mobile {
 		 * @param {string} deviceId The unique identifier of the device.
 		 * @param {Mobile.IiOSLogStreamOptions} options Describes the options which can be passed
 		 */
-		startLogProcess(deviceId: string, options?: Mobile.IiOSLogStreamOptions): void;
+		startLogProcess(deviceId: string, options?: Mobile.IiOSLogStreamOptions): Promise<void>;
 		/**
 		 * Starts a new process for getting simulator logs and emits and DEVICE_LOG_EVENT_NAME event. The event's reponse is with muted=true flag so it will not be printed from deviceLogProvider.
 		 * @param {string} deviceId The unique identifier of the device.

mobile/ios/simulator/ios-simulator-application-manager.ts

@@ -32,15 +32,15 @@ export class IOSSimulatorApplicationManager extends ApplicationManagerBase {
 			}
 		}
 
-		this.iosSim.installApplication(this.device.deviceInfo.identifier, packageFilePath);
+		return this.iosSim.installApplication(this.device.deviceInfo.identifier, packageFilePath);
 	}
 
 	public async uninstallApplication(appIdentifier: string): Promise<void> {
 		return this.iosSim.uninstallApplication(this.device.deviceInfo.identifier, appIdentifier);
 	}
 
 	public async startApplication(appData: Mobile.IApplicationData): Promise<void> {
-		const launchResult = this.iosSim.startApplication(this.device.deviceInfo.identifier, appData.appId);
+		const launchResult = await this.iosSim.startApplication(this.device.deviceInfo.identifier, appData.appId);
 		const pid = getPidFromiOSSimulatorLogs(appData.appId, launchResult);
 		await this.setDeviceLogData(appData, pid);
 	}
@@ -87,7 +87,7 @@ export class IOSSimulatorApplicationManager extends ApplicationManagerBase {
 			return null;
 		}
 
-		const applicationPath = this.iosSim.getApplicationPath(this.device.deviceInfo.identifier, appIdentifier),
+		const applicationPath = await this.iosSim.getApplicationPath(this.device.deviceInfo.identifier, appIdentifier),
 			pathToInfoPlist = path.join(applicationPath, "Info.plist");
 
 		return this.$fs.exists(pathToInfoPlist) ? await this.$plistParser.parseFile(pathToInfoPlist) : null;

mobile/ios/simulator/ios-simulator-device.ts

@@ -58,7 +58,7 @@ export class IOSSimulator implements Mobile.IiOSSimulator {
 	public async openDeviceLogStream(options?: Mobile.IiOSLogStreamOptions): Promise<void> {
 		this._deviceLogHandler = this.onDeviceLog.bind(this, options);
 		this.$iOSSimulatorLogProvider.on(constants.DEVICE_LOG_EVENT_NAME, this._deviceLogHandler);
-		this.$iOSSimulatorLogProvider.startLogProcess(this.simulator.id, options);
+		return this.$iOSSimulatorLogProvider.startLogProcess(this.simulator.id, options);
 	}
 
 	public detach(): void {

mobile/ios/simulator/ios-simulator-log-provider.ts

@@ -18,9 +18,9 @@ export class IOSSimulatorLogProvider extends EventEmitter implements Mobile.IiOS
 		this.shouldDispose = shouldDispose;
 	}
 
-	public startLogProcess(deviceId: string, options?: Mobile.IiOSLogStreamOptions): void {
+	public async startLogProcess(deviceId: string, options?: Mobile.IiOSLogStreamOptions): Promise<void> {
 		if (!this.simulatorsLoggingEnabled[deviceId]) {
-			const deviceLogChildProcess: ChildProcess = this.$iOSSimResolver.iOSSim.getDeviceLogProcess(deviceId, options ? options.predicate : null);
+			const deviceLogChildProcess: ChildProcess = await this.$iOSSimResolver.iOSSim.getDeviceLogProcess(deviceId, options ? options.predicate : null);
 
 			const action = (data: NodeBuffer | string) => {
 				const message = data.toString();