Use async API from ios-sim

Fixes NativeScript/nativescript-cli#3545

Author: Fatme

appbuilder/providers/device-app-data-provider.ts

@@ -102,7 +102,7 @@ export class IOSAppIdentifier extends AppBuilderDeviceAppDataBase implements ILi
 	@cache()
 	public async getDeviceProjectRootPath(): Promise<string> {
 		if (this.device.isEmulator) {
-			const applicationPath = this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
+			const applicationPath = await this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
 			return path.join(applicationPath, "www");
 		}
 
@@ -127,7 +127,7 @@ export class IOSNativeScriptAppIdentifier extends AppBuilderDeviceAppDataBase im
 	@cache()
 	public async getDeviceProjectRootPath(): Promise<string> {
 		if (this.device.isEmulator) {
-			const applicationPath = this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
+			const applicationPath = await this.$iOSSimResolver.iOSSim.getApplicationPath(this.device.deviceInfo.identifier, this.appIdentifier);
 			return applicationPath;
 		}
 

definitions/mobile.d.ts

@@ -210,7 +210,7 @@ declare module Mobile {
 		 * Starts the process for getting simulator logs and sends collected data to deviceLogProvider, which should decide how to show it to the user.
 		 * @param {string} deviceIdentifier The unique identifier of the device.
 		 */
-		startLogProcess(deviceIdentifier: string): void;
+		startLogProcess(deviceIdentifier: string): Promise<void>;
 	}
 
 	/**

mobile/ios/simulator/ios-simulator-application-manager.ts

@@ -32,26 +32,27 @@ export class IOSSimulatorApplicationManager extends ApplicationManagerBase {
 			}
 		}
 
-		this.iosSim.installApplication(this.identifier, packageFilePath);
+		await this.iosSim.installApplication(this.identifier, packageFilePath);
 	}
 
 	public async uninstallApplication(appIdentifier: string): Promise<void> {
 		return this.iosSim.uninstallApplication(this.identifier, appIdentifier);
 	}
 
 	public async startApplication(appData: Mobile.IApplicationData): Promise<void> {
-		const launchResult = this.iosSim.startApplication(this.identifier, appData.appId);
+		const launchResult = await this.iosSim.startApplication(this.identifier, appData.appId);
 		const pid = launchResult.split(":")[1].trim();
 		this.$deviceLogProvider.setApplicationPidForDevice(this.identifier, pid);
 		this.$deviceLogProvider.setProjectNameForDevice(this.identifier, appData.projectName);
 
 		if (!this.$options.justlaunch) {
-			this.$iOSSimulatorLogProvider.startLogProcess(this.identifier);
+			await this.$iOSSimulatorLogProvider.startLogProcess(this.identifier);
 		}
 	}
 
 	public async stopApplication(appData: Mobile.IApplicationData): Promise<void> {
-		return this.iosSim.stopApplication(this.identifier, appData.appId, appData.projectName);
+		const result = await this.iosSim.stopApplication(this.identifier, appData.appId, appData.projectName);
+		return result;
 	}
 
 	public async getApplicationInfo(applicationIdentifier: string): Promise<Mobile.IApplicationInfo> {
@@ -83,7 +84,7 @@ export class IOSSimulatorApplicationManager extends ApplicationManagerBase {
 			return null;
 		}
 
-		const applicationPath = this.iosSim.getApplicationPath(this.identifier, appIdentifier),
+		const applicationPath = await this.iosSim.getApplicationPath(this.identifier, appIdentifier),
 			pathToInfoPlist = path.join(applicationPath, "Info.plist");
 
 		return this.$fs.exists(pathToInfoPlist) ? await this.$plistParser.parseFile(pathToInfoPlist) : null;

mobile/ios/simulator/ios-simulator-device.ts

@@ -52,6 +52,6 @@ export class IOSSimulator implements Mobile.IiOSSimulator {
 	}
 
 	public async openDeviceLogStream(): Promise<void> {
-		this.$iOSSimulatorLogProvider.startLogProcess(this.simulator.id);
+		await this.$iOSSimulatorLogProvider.startLogProcess(this.simulator.id);
 	}
 }

mobile/ios/simulator/ios-simulator-log-provider.ts

@@ -9,9 +9,9 @@ export class IOSSimulatorLogProvider implements Mobile.IiOSSimulatorLogProvider
 		private $logger: ILogger,
 		private $processService: IProcessService) { }
 
-	public startLogProcess(deviceIdentifier: string): void {
+	public async startLogProcess(deviceIdentifier: string): Promise<void> {
 		if (!this.simulatorsLoggingEnabled[deviceIdentifier]) {
-			const deviceLogChildProcess: ChildProcess = this.$iOSSimResolver.iOSSim.getDeviceLogProcess(deviceIdentifier, 'senderImagePath contains "NativeScript"');
+			const deviceLogChildProcess: ChildProcess = await this.$iOSSimResolver.iOSSim.getDeviceLogProcess(deviceIdentifier, 'senderImagePath contains "NativeScript"');
 
 			const action = (data: NodeBuffer | string) => {
 				this.$deviceLogProvider.logData(data.toString(), this.$devicePlatformsConstants.iOS, deviceIdentifier);