Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kendo Observable is missing properties in TypeScript 3.9 #5973

Closed
veselints opened this issue Aug 17, 2020 · 2 comments
Closed

Kendo Observable is missing properties in TypeScript 3.9 #5973

veselints opened this issue Aug 17, 2020 · 2 comments
Assignees
Labels
Bug FP: Completed Sync status with associated Feedback Item jQuery SEV: Medium TypeScript
Milestone

Comments

@veselints
Copy link
Contributor

veselints commented Aug 17, 2020

Bug report

Due to the following change in TypeScript (microsoft/TypeScript#32264 (comment)), in some scenarios, the Kendo observable is missing properties in TypeScript 3.9.

Reproduction of the problem

Steps to reproduce the issue are present in Support thread 1480700

Expected/desired behavior

Observable creation logic should not rely on the enumeration of property definitions.

Environment

  • Kendo UI version: 2020.2.617
@kendo-bot kendo-bot added the FP: Unplanned Sync status with associated Feedback Item label Aug 17, 2020
@benpetermorris
Copy link

benpetermorris commented Aug 26, 2020

This is a significant problem for everyone using TypeScript + Kendo; without a workaround, upgrading to TypeScript 3.9 is impossible. Please reconsider the severity assigned to this issue.

@Iankodj Iankodj self-assigned this Oct 12, 2020
@Iankodj Iankodj closed this as completed Oct 12, 2020
@kendo-bot kendo-bot added FP: Planned Sync status with associated Feedback Item FP: Completed Sync status with associated Feedback Item and removed FP: Unplanned Sync status with associated Feedback Item FP: Planned Sync status with associated Feedback Item labels Oct 12, 2020
@Iankodj Iankodj reopened this Oct 13, 2020
@kendo-bot kendo-bot added FP: In Development Sync status with associated Feedback Item and removed FP: Completed Sync status with associated Feedback Item labels Oct 13, 2020
@kendo-bot kendo-bot added FP: Completed Sync status with associated Feedback Item and removed FP: In Development Sync status with associated Feedback Item labels Oct 19, 2020
@mparvanov mparvanov added this to the 2020.R3.SP.next milestone Oct 19, 2020
@mparvanov
Copy link
Contributor

The following setup could be used for testing:

/// <reference path="jquery.d.ts" />
/// <reference path="kendo.all.d.ts" />

  
  $(function () {
 
    class EncounterClass {
      registration: any;
      constructor () {
        this._mrn = "initial value";
      }
          _mrn: string;
          public get mrn(): string {
              if (this.registration) {
                  return this.registration.mrn;
              }
              return this._mrn;
          }
          public set mrn(value: string) {
              this._mrn= value;
          }
    }
    
    var array =new kendo.data.ObservableArray([new EncounterClass(), new EncounterClass()])
    console.log(array);
    
    
      $("#grid2").kendoGrid({
      columns: [
       
        { field: "mrn", template: (encounter) => {
            return `<span id="area${encounter.mrn}" >${encounter.mrn}</span>`;
        } }
      ],
      dataSource: array,
    });
   
  });
  
  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug FP: Completed Sync status with associated Feedback Item jQuery SEV: Medium TypeScript
Projects
None yet
Development

No branches or pull requests

5 participants