Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actual "x-ratelimit-limit" in API request callbacks not provided #30

Closed
beebs93 opened this issue Aug 20, 2014 · 1 comment
Closed

Actual "x-ratelimit-limit" in API request callbacks not provided #30

beebs93 opened this issue Aug 20, 2014 · 1 comment

Comments

@beebs93
Copy link

beebs93 commented Aug 20, 2014

The "limit" variable you are passing to callbacks is not the "x-ratelimit-limit" header, but the "x-ratelimit-remaining". It would be helpful to have both values passed instead of just the one.

https://github.com/teleportd/instagram-node/blob/master/lib/instagram.js#L163

I guess the simplest solution would be parse out that other header and pass it along as another argument to callbacks.

EDIT: Link to file added

n1t0 pushed a commit that referenced this issue Aug 22, 2014
@n1t0
Copy link
Member

n1t0 commented Aug 22, 2014

Addressed by #31

@n1t0 n1t0 closed this as completed Aug 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants