Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace various module-code-snippets with generics #229

Open
KristianLyng opened this issue May 9, 2022 · 0 comments
Open

Replace various module-code-snippets with generics #229

KristianLyng opened this issue May 9, 2022 · 0 comments
Labels
core/config Anything dealing with the configuration subsystem core/modules Anything dealing with the general module support enhancement New feature or request

Comments

@KristianLyng
Copy link
Collaborator

A number of plumbing-parts for modules are basically copy/paste, and should be replaced with generics.

E.g.: The logic for resolving SenderMap. One small hitch is that the SenderRef (with family) uses foo.S while ParserRef uses foo.P etc, which probably means some minor refactoring, but now that we have senders, handlers, parsers, receivers and encoders, the code duplication is becoming a chore and a source of worry with regards to bugs and feature parity between modules.

@KristianLyng KristianLyng added enhancement New feature or request core/config Anything dealing with the configuration subsystem core/modules Anything dealing with the general module support labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core/config Anything dealing with the configuration subsystem core/modules Anything dealing with the general module support enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant