-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building from source on Windows 10 #26012
Comments
Hey there! This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own. Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue. Thanks! |
I'm not the one who's opened this, but it still happens in the latest dev |
Not sure if my comment can help to keep this issue open, but lets give a shot (but I don't this would help to address the issue lol). |
This happens for me too with the latest version. Windows 11 x64.
Can anyone look into this bug? There seems to be a duplicate key being added twice during execution. |
Yeah, I'm getting this too. Is it a Windows 10 thing (does it not happen on Windows 11)? Can anyone actually get Telegram Desktop to build on Windows 10? |
The issue is with the build of
|
Same for me on Windows 11 |
+1 on this on Windows 11. On a lark I even removed the VS2022 version of CMake and had the build rely on the one installed as part of the official instructions, same result. Now time to go spin up a Win10 VM and see if there is a difference. Also, I suspect the build instructions are out of date, as I had issues earlier on without WSL being installed. |
I found the topic https://developercommunity.visualstudio.com/t/Build-Error:-MSB6001-in-Maven-Build/10527486?sort=newest. I found the follow script: |
@spobit I'm getting the 'Item has already been added' error before the following completes:
Because it's not even getting through the configure stage, I have no |
@jez9999 Me to. the error is libvpx. after the error happened, build vpx.sln by vs, and then make --prefix=../local install. please see vpx script (my first picture) how to do. |
In which directory do you run |
|
I don't have bash though, I'm in the x64 Native Tools command prompt for VS 2022 on Windows. |
@jez9999 , were you able to resolve this solution? |
@spobit , I would be really thankful if you could provide video of solving this VPX issue. |
spobit, did you just run bash? I have a message '$ make |
@jez9999 @EugenySychev |
Yeah it probably is easy, but the point is it seems like a totally unsupported setup. Where did you get instructions that you needed to use that make.exe during the build process, or did you cobble an environment together through trial and error? You shouldn't have to do that to build the client! What happens when something breaks and people ask "why are you using make on Windows?" |
I concur. If merely following these was enough, this issue wouldn't be raised. But I do understand why those hasn't been updated on their own or by patching some of the scripts. |
"building is an unsupported feature" 🤣 |
@timocov Do you still repro this issue? If yes, could you follow Details on sharing binary logs and share the logs? so, we can conduct further research. |
@EugenySychev |
@JaynieBai sorry I gave up a long time ago and haven't tried since :( |
|
Go to BuildPath\tdesktop\Telegram and run (using your api_id and api_hash) configure.bat x64 -D TDESKTOP_API_ID=YOUR_API_ID -D TDESKTOP_API_HASH=YOUR_API_HASH |
|
|
congratulations |
hope it's finally fixed, now waiting for release |
fixed vcredist avaliable at https://aka.ms/vs/17/release/vc_redist.x64.exe |
so i can close? |
now i'm trying to build, i will notice if build succeeds. |
update: vcredist_x64 does not installs in MSVC folder in Visual Studio folder idk how to make it install right way |
Yikes, what a mess that VS bug report is. So installing a new version of VS will not fix this, because it's in some VC redistributable libraries that don't get updated by Visual Studio apparently. |
Unfortunately the issue isn't solved at all in MSVC, because the static libs that are used in TDesktop were not updated in any redist / msvc version yet, see my new (accepted, unresolved) bug report: https://developercommunity.visualstudio.com/t/Illegal-Instruction-POPCNT-emitted-in-MS/10576397 |
(btw last ~ten messages were discussing not the fix for this issue, but the fix for the MSVC problem that stops me from updating MSVC toolchain used by me, after what this issue will start reproducing for me as well) |
@john-preston i guess you can try installing clean VS 2022 with latest 17.8 (or 17.9 preview) toolchain on maybe second device or VM? to check if you can reproduce that |
This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further. |
https://developercommunity.visualstudio.com/t/Illegal-Instruction-POPCNT-emitted-in-MS/10576397#T-N10587252 a fix have been pushed, who knows when it will be released. |
I guess he hints that the community could look at the issue rather than waiting for him to look. |
I've done that... spun up a Win11 dev machine with Hyper-V (includes some build of VS 2022 Community) (I don't currently have Win11 media on hand for quick spin ups), removed it, installed VS 2022 Community 17.10.0 Preview 1.0... and same results, duplicate key as described by others above, and which I'd hit the same place with earlier builds as well. |
Read through whole thread + various other external bugreports, I understood that MS is not very keen to fix that.
I don't think it is right to fix it on libvpx side. It worked for me in following environments
@john-preston PR for patches: desktop-app/patches#182
|
Thank you for resolving this issue! This is great. I've merged the patches PR, so now you can make a PR here that will reference the new upstream patches commit. |
|
Steps to reproduce
Expected behaviour
No errors while running
tdesktop\Telegram\build\prepare\win.bat
Actual behaviour
Cannot build
libvpx
package.Log
Operating system
Win10 x64
Version of Telegram Desktop
Building from de9a757
Installation source
Other (unofficial) source
Logs
No response
The text was updated successfully, but these errors were encountered: