Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support the system window frame for the Voice Chat window #10002

Open
xmha97 opened this issue Dec 25, 2020 · 26 comments
Open

Comments

@xmha97
Copy link

xmha97 commented Dec 25, 2020

Please support the system window frame for the Voice Chat window.
Telegram

@Demetri0
Copy link

Demetri0 commented Feb 20, 2021

Also for 1-1 voice call dialog, please.

@andrei-a-papou
Copy link

I second that. Right now on Ubuntu 20.04 LTS the call window's titlebar looks really out of place... Thankfully, the main window's decorations look fine.

@ilya-fedin Could you comment on why the Use system window frame setting doesn't apply to call windows? This looks inconsistent in terms of UX.

@ilya-fedin
Copy link
Contributor

Could you comment on why the Use system window frame setting doesn't apply to call windows?

Because @john-preston doesn't want to provide that option for these windows

@andrei-a-papou
Copy link

@ilya-fedin I'm not sure I follow the logic here... There's an option that says Use system window frame. Clearly when a user ticks it, they expect system titlebars across the entire application, for all windows, correct?

It's just not good UX to mix system and client-side decorations. Different look. Possibly different position, if the user places their system decorations on the left, for example.

So right now the option is there, under Settings, but it doesn't apply to all windows, just to some. Why would anyone want bad UX for Telegram? :) Or am I misunderstanding something?

@ilya-fedin
Copy link
Contributor

Your words are useless, I don't decide anything here

@xmha97
Copy link
Author

xmha97 commented Aug 9, 2021

Your words are useless,

I completely agree with @andrei-a-papou.

I don't decide anything here

Also, if you do not care about our requests, please disable the issue section on GitHub.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Aug 9, 2021

Also, if you do not care about our requests, please disable the issue section on GitHub.

As I already said: I don't decide anything here

@lokpozzta
Copy link

lokpozzta commented Aug 9, 2021 via email

@lokpozzta
Copy link

lokpozzta commented Aug 9, 2021 via email

@stale
Copy link

stale bot commented Feb 6, 2022

Hey there!

This issue was inactive for a long time and will be automatically closed in 30 days if there isn't any further activity. We therefore assume that the user has lost interest or resolved the problem on their own.

Don't worry though; if this is an error, let us know with a comment and we'll be happy to reopen the issue.

Thanks!

@stale stale bot added the stale label Feb 6, 2022
@Demetri0
Copy link

Demetri0 commented Feb 6, 2022

The problem is still not solved

@Nikita-Presnov
Copy link

@john-preston, pay attention to this issue.
A bug with moving windows may pop up.
Not to mention that it is simply ugly when using certain themes, such as in Windows 7.
Purely in my opinion, your csd is not so functional to hold onto it, it does not integrate well into the system, it's just extra work.

@Demetri0
Copy link

Demetri0 commented Apr 6, 2023

+1 for bug with moving window. (But haven't tested on latest telegram versions)

Also want to add: That current video call window doesn't support such options like: "Always on top" and "Always on visible Workspace" and other really important options.

@ilya-fedin
Copy link
Contributor

I believe you can enable options like always on top with system-wide hotkeys

@Demetri0
Copy link

Demetri0 commented Apr 6, 2023

Probably yes, I don't know such hotkeys, will need to google it.
But any way it's much easier and comfortable to have this options just by right-click on window frame.

@ilya-fedin
Copy link
Contributor

Well, tdesktop has the code to call system window menu, it's just there's no right click handler in the voice chat window.

@ilya-fedin
Copy link
Contributor

There's no bug report for that, that's probably why it's not implemented.

@Demetri0
Copy link

Demetri0 commented Apr 6, 2023

Can I ask why tdesktop team so dislike system window frames? Is there any reason for that? :)

@ilya-fedin
Copy link
Contributor

I don't know exactly, but I guess that's designer's decision: that's how the window looks on the mockup and the developer has to implement the mockup pixel-perfect

@Demetri0
Copy link

Demetri0 commented Apr 7, 2023

It's really sad when designers doesn't respects user experience, and think only about single application, and not about how this application looks in general system design near with other applications. ;'(

Actually I'm very excited with most tdesktop design, but this decision look really weird for me: I can adjust colors of telegram to be more-less consistent with color scheme of my system, but I can't make frame of window to be comfortable and pretty for me.
Thanks that main window still have this option, I'm afraid at some day and this option may be removed :)

I hope more people vote this issue to give it more weight. (If it is matter for tdesktop designers :))

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Apr 7, 2023

The content of the window doesn't look like the rest of the system, why the frame should? It has sense for it to look like the content of the window it's drawn around, not the content of other windows.

About the option, yes, @john-preston was saying the option is here only due to bugs in the frame implementation, he'd like to remove the option completely or move it to experimental options at least (as people enable it and then report design bugs). The Windows bug with maximized geometry handling was finally fixed recently, there's also work to use system resize on Windows 11 with custom frame and Qt changes to fix the event handling on X11 and Wayland, so the option indeed could disappear sooner than later. macOS never had it for instance, it always uses custom frame.

@ilya-fedin
Copy link
Contributor

ilya-fedin commented Apr 7, 2023

(If it is matter for tdesktop designers :))

No, it's not, the only place they read is https://t.me/designers. They're not public people. This tracker is not even an official place (as opposed to the in-app support and https://bugs.telegram.org, but the latter has no enough moderators and most issues seem to be skipped).

@Demetri0
Copy link

Demetri0 commented Apr 7, 2023

The content of the window doesn't look like the rest of the system, why the frame should?

Probably you are right, and it is just a luck that content of tdesktop doesn't look alien for my system design.

@Nikita-Presnov
Copy link

The content of the window doesn't look like the rest of the system, why the frame should? It has sense for it to look like the content of the window it's drawn around, not the content of other windows.

Totally disagree, and damn it, I want all applications to have a similar design, including the theme, approach to the layout of elements and hotkeys, although this is not possible for the last 2 points.

@ilya-fedin
Copy link
Contributor

I want all applications to have a similar design

Well, you can use Unigram or Telegram for macOS if you're using one of the system they support or create your own client. This is not a goal for tdesktop, sorry. Its goal is to have a uniform cross-platform design.

@RokeJulianLockhart
Copy link

#26481 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants