-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LoadBalancerClass support in EventListener #1708
Conversation
|
Hi @nicolasbernard. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
11cb932
to
5a6e0e7
Compare
/kind feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@nicolasbernard Please sign the cla. |
The following is the coverage report on the affected files.
|
I did, at least I tried, if the bot didn't update, it means I did something wrong? Edit: Should be good. |
524f54c
to
14c4cb7
Compare
The following is the coverage report on the affected files.
|
14c4cb7
to
53b1c13
Compare
The following is the coverage report on the affected files.
|
53b1c13
to
1e13068
Compare
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nicolasbernard
Two things
- Can you update PR description about the usecase behind this feature basically give an end user usecase
- Add release note section as there is a new field support
38ab760
to
888a0bb
Compare
The following is the coverage report on the affected files.
|
888a0bb
to
87242c4
Compare
The following is the coverage report on the affected files.
|
87242c4
to
c154771
Compare
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: savitaashture The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolasbernard Can you please rebase this asap so that we can include this in the current release?
c154771
to
e94f8f5
Compare
The following is the coverage report on the affected files.
|
@khrm Should be good, thanks you for making it happen :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
Add the ability to define the service
spec.loadBalancerClass
for EventListener with a Service of typeLoadBalancer
.It's useful if your cluster has multiples LoadBalancer controllers and you need to choose on which one you want to expose the EventListener, for example you can have one controller for public IPs and another for privates IPs.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes