-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain line and character number after parsing #86
Comments
This is a little finicky right now unless we want to store (invalid) line number information on all objects because the AST structures are objects themselves. Perhaps we should separate them out (ehhhh) or find another way to do a mixin or something. |
the reasoning is a little weird but i think we can calculate the line/col from the byte position easily and it's only one number to store |
I saw/skimmed part of a cool talk that did this for Circle, I think. Perhaps this talk https://www.youtube.com/watch?v=1m_5SVmGA4k They have some cool tricks |
Oh, no, lmao, it was Carbon: https://www.youtube.com/watch?v=ZI198eFghJk |
Evaluation has many failure cases, many of which have pretty reasonable error messages. However we do not maintain the line and character numbers associated with nodes in the AST. The interpreter can't point to the part of the code associated with a failure that occurs during evaluation.
This feature request is to make code index information available in the evaluation stage.
The text was updated successfully, but these errors were encountered: