-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to compile FW #188
Comments
Thanks for the swift response. For anyone else reading this, I was able to install the MPLABS X IDE from their website. All I had to do was open the project and in the project directory use Thanks @tedsalmon. I'm in experienced with this, I was curious if you could have a quick look at the changes I made to see if everything is OK? I don't mind contributing the changes, but they really just comes down to personal preference. See the changes here: Thoughts? Thanks |
Your changes will work but you are removing functionality (the strings) and inverting existing functionality (play/pause) - as you say it's personal preference. Very unlikely you'll get these changes accepted. If you really want set your preferences, you'd be better off making them a configurable option (defaulting to the current method). Even then I'm not sure Ted will want to get to that level of tweaking for these kinds of things. Or just create a patch and apply it to whatever the current version is and build your own each time. Every now and then you may need to update your patch to apply it cleanly. Or just run your fork and rebase it off the parent to bring in anything new from the main repo. Basically the same thing. |
Thanks for sharing your changes! As @HDC67 mentioned, this is all very subjective. For example, I think inverting Pause / Play from the current state to the desired state is a war crime :P. However, many artists and platforms (looking at YouTube Music) are slowly moving away from the "Album", so it makes sense that omitting this is becoming more widely popular. I'd be happy to include this as a UI setting where in you can stipulate different metadata options such as:
Now, I'm not asking you to do any of this, just spit balling how I would actually implement it. I'll probably add this to the list once 1.4.0 is squared away. Thanks! |
Thanks @tedsalmon .. but can we at least talk about it? Lol. When you playback music on any device, does it present you with a Pause button or the play button? Why should this be different?
I'd appreciate that.. thank you. Yes, removing the album would be ideal. Not because I don't want to see the album.. but only because the real estate on the screen is so limited. So having that flexibility to choose between the 3 options there, that would be great. That's also why I think the word "Bluetooth" on screen while metadata is being presented is redundant and inefficient. The changes I posted above didn't actually end up working out. The changes:
There is a bug that when playback is paused, it shows Paused on the screen and it just stays like that even when playback is resumed. Not sure why though. Please keep in mind that I have zero C experience, so I have no idea how to solve it. Any advice would be great but it's not a huge bug that bothers me a lot. In a perfect world, I think the metadata should scroll back and forth instead of starting over when it reaches the end. But that's way beyond my noob abilities 😆 . |
To lend you some credence, this UX makes more sense with the MID UI as the indicator is directly above the toggle. Both of my cars have Navigation, so it plays the role of a status indicator. I didn't want to change the logic per-UI, and at this point I quite like how it works. I would be more than willing to accept a PR where you break this out into a configuration bit/byte that can be used to toggle the behavior on the MID.
Previously, "Bluetooth" was statically pinned on the left, as this is standard for the radio UI. When I switched to the TEL UI, I got access to a lot more screen real estate as a giant blob rather than discreet screen spaces. It carried over but I didn't both to maintain "Bluetooth" statically on the left. Ideally, It should display "Bluetooth" at all times on the left, or even just "BT" to carry over from the OE functionality. To be clear, I do not want to remove the "mode indicator", much like terrestrial radio shows AM/FM on the left. I am a bit unclear how RDS presents on a MID and I wasn't immediately able to find an example on YT, though.
There's probably something wrong in the event handler for playback state. I'll have a look. -Ted |
Hi,
Really like my Bluebus but I wanted to make some minor changes to the firmware for the Bluebus UI/UX.. I'm totally new at this stuff, so please bear with me.
I've made the changes I was looking for in the firmware/application folder.. I'm not sure how to go about compiling the new firmware. I'd love to contribute, but of course, testing is required.
When I run make clean && make I get this error:
Could someone kindly please post a step by step on what I need to do to actually compile this and how to load it onto the Bluebus after compilation?
Thank you
The text was updated successfully, but these errors were encountered: