Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTX's new virtual key events #349

Open
teckel12 opened this issue Sep 23, 2019 · 5 comments
Open

Support OpenTX's new virtual key events #349

teckel12 opened this issue Sep 23, 2019 · 5 comments
Assignees
Milestone

Comments

@teckel12
Copy link
Owner

Is your feature request related to a problem? Please describe

OpenTX v2.3 adds new virtual key events that simplifies the controls of multiple controllers.

Describe the solution you'd like

Clean up Lua Telemetry code to use the virtual key events

Describe alternatives you've considered

Continue the painful way it's being done now, where every controller needs to be hand-built.

Additional context

For Lua Telemetry to continue to work with older versions of OpenTX, detecting of missing virtual key events will be required. Another option is to require OpenTX 2.3, but I don't think that can be done till a later date (but will be done at some point so legacy code can be removed). Maybe 6 months after OpenTX 2.3 is released it's made a requirement of Lua Telemetry?

@teckel12 teckel12 self-assigned this Sep 23, 2019
@teckel12 teckel12 added this to the Future milestone Sep 30, 2019
@teckel12
Copy link
Owner Author

I'll wait till the beginning of 2020 to switch over to using the virtual key events. Seems EVT_VIRTUAL_MENU is missing from the Jumper T12 and there could be other issues I'm not aware of at this time. By January of 2020 it's not unrealistic to require OpenTX 2.3+

@LawrenceLDJr
Copy link

Jumper T12, INav and OpenTX 2.3.4, new key config, naming, mapping, configuration of the T12s 6 buttons has a different instruction set in OpenTX. I imagine this is why only the enter key works with INav now. Sounds like a simple fix. Happy Holidays

@jj-uk
Copy link

jj-uk commented Feb 19, 2020

Is there a branch anywhere that contains the required changes for OpenTx 2.3.5 compatibility ?

I don't know anything about LUA or how to write it, but if its a find/replace I might be able to add the changes, maybe... My USB port on the flight controller is not really accessible in my model so would really like to use this as soon as its available.

@teckel12
Copy link
Owner Author

@jj-uk There's not currently a branch with support for the new virtual key events. It's more than just a simple search and replace. The change will break anyone using OpenTX prior to v2.3 which is why it hasn't been changed yet. Once the switch has happened, OpenTX 2.3 will be required. This spring (as it's currently too cold to fly where I'm from).

@jj-uk
Copy link

jj-uk commented Apr 1, 2020

There's a fix in Open-tx 2.3.6 that addresses issues with the + - Exit buttons. Not sure if this is related?
opentx/opentx#7356

@teckel12 teckel12 modified the milestones: Future, 1.7.3 Jul 7, 2020
@nm17 nm17 pinned this issue Feb 20, 2021
@teckel12 teckel12 unpinned this issue Feb 25, 2021
@teckel12 teckel12 modified the milestones: 1.7.3, 1.8.0 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants