Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Remove OutputCallback from IConnectionCallbackHandler #179

Open
MV10 opened this issue Sep 5, 2020 · 0 comments
Open

Remove OutputCallback from IConnectionCallbackHandler #179

MV10 opened this issue Sep 5, 2020 · 0 comments

Comments

@MV10
Copy link
Collaborator

MV10 commented Sep 5, 2020

As discussed recently, the OutputCallback in IConnectionCallbackHandler doesn't make sense. The buffer is not meant to contain data, it's a source of unused buffers. The else portion of the if-else block in MMALConnectionImpl's NativeConnectionCallback method invokes the callback, but the buffer Length is always zero, so it is never actually executed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant