-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we rationalise our test data classes? #22
Comments
Yes, good point. I think we can wrap up a few of those and then use a repository pattern to instantiate a list of data that can be used to create a table. At first glance, 1-3 can be consolidated. Just need enough properties to demonstrate all of the current and planned API features.
I'm not sure if we can do the same with #4 though. It's explicit purpose is to be invalid via having only properties that are not accessible in the API. |
Completely agree re number 4. For the others, I think consolidating them into just one type is a good ambition. Off the top of my head, the following types would be useful as columns:
The numbers and datetime are useful for demonstrating the format string capabilities. It feels like having more than one string column (I'm thinking ahead to features like string transforms and overflow handling.) What will make this complex is re-writing the tests to match the updated type(s). Random questions:
|
I agree with those columns. Regarding the random questions:
|
Currently we have four classes in the ConTabsTestData project that exist solely for the purposes of testing and demoing:
DemoDataType
TestDataType
MinimalDataType
InvalidTestDataType
This seems like too many. (And we're proposing another called
DemoAnimals
in #21)It seems to me that at most we'd need one for testing, one for demoing and one that's invalid. We may even be able to collapse testing and demoing into a single class.
Can we make a list of things that would be useful in each scenario? Once we've done that, we may be able to rationalise this list into a smaller one, which will be more lightweight and easier to maintain.
The text was updated successfully, but these errors were encountered: