Skip to content
This repository was archived by the owner on Oct 19, 2023. It is now read-only.

Fix Identifier.identifier #377

Closed
essvee opened this issue Aug 4, 2022 · 3 comments · Fixed by #384
Closed

Fix Identifier.identifier #377

essvee opened this issue Aug 4, 2022 · 3 comments · Fixed by #384
Assignees
@jbstatgen
Labels
review Changes to be made following feedback from internal reviewers

Comments

@essvee
Copy link
Contributor

essvee commented Aug 4, 2022 •
edited
Loading

Notes from review meeting: 2022-07-28

ltc:Identifier.identifier is currently mapped to dcterms:identifier, but it shouldn't be. We need to update it to work in the same way as ContactDetail and ContactDetail.contactDetailValue

Probably best to do this one in both the issue and the termlist csv, once we've got a review branch set up?
@essvee essvee added the review Changes to be made following feedback from internal reviewers label Aug 4, 2022
@jbstatgen
Copy link
Collaborator

Change of term name to Identifier.identifierValue - DONE
Added info to new wiki page https://github.com/tdwg/cd/wiki/Changes-during-review

The mapping question is still open.

@essvee essvee assigned essvee and jbstatgen and unassigned essvee Aug 5, 2022
@essvee essvee mentioned this issue Aug 5, 2022
Merged
@essvee essvee linked a pull request Aug 5, 2022 that will close this issue
Sarah/383 event name #384
Merged
@essvee
Copy link
Contributor Author

essvee commented Aug 11, 2022

Closing - PR #384. Mapping should be handled as part of #372

@essvee essvee closed this as completed Aug 11, 2022
@jbstatgen
Copy link
Collaborator

Finally, done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbstatgen jbstatgen

Labels
review Changes to be made following feedback from internal reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sarah/383 event name tdwg/cd
2 participants
@essvee @jbstatgen