Skip to content

Commit f87ace6

Browse files
remove the TODO and add resolved condition for HiveTable
1 parent a8260e8 commit f87ace6

File tree

1 file changed

+2
-2
lines changed
  • sql/hive/src/main/scala/org/apache/spark/sql/hive

1 file changed

+2
-2
lines changed

sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveQl.scala

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,11 @@ case class CreateTableAsSelect(
6464

6565
override def output: Seq[Attribute] = Seq.empty[Attribute]
6666
override lazy val resolved: Boolean =
67-
// TODO add more condition?
6867
tableDesc.specifiedDatabase.isDefined &&
6968
tableDesc.schema.size > 0 &&
7069
tableDesc.serde.isDefined &&
70+
tableDesc.inputFormat.isDefined &&
71+
tableDesc.outputFormat.isDefined &&
7172
childrenResolved
7273
}
7374

@@ -254,7 +255,6 @@ private[hive] object HiveQl {
254255

255256
/**
256257
* Returns the HiveConf
257-
* TODO get it from HiveContext?
258258
*/
259259
private[this] def hiveConf(): HiveConf = {
260260
val ss = SessionState.get() // SessionState is lazy initializaion, it can be null here

0 commit comments

Comments
 (0)