Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider add_editor_style. #53

Closed
tcmulder opened this issue Aug 15, 2023 · 4 comments
Closed

Reconsider add_editor_style. #53

tcmulder opened this issue Aug 15, 2023 · 4 comments

Comments

@tcmulder
Copy link
Owner

Using add_editor_style in includes/blocks.php causes @container querries to break, and it looks like there are many other issues. Some use enquque_block_editor_assets as a workaround: is that plausible, now that gutenberg is within an iframe?

Secondarily, does that allow Browsersync to work on the back-end...? 🤞

@tcmulder tcmulder converted this from a draft issue Aug 15, 2023
@tcmulder
Copy link
Owner Author

Could potentially test this via the aquamin/grd Grid block.

@tcmulder tcmulder moved this from Todo to In Progress in Aquamin Theme Updates Aug 15, 2023
@tcmulder tcmulder moved this from In Progress to Todo in Aquamin Theme Updates Aug 15, 2023
@tcmulder tcmulder moved this from Todo to In Progress in Aquamin Theme Updates Aug 15, 2023
@tcmulder
Copy link
Owner Author

Note: this sorta works, except for some reason it won't load on the back-end over the Browsersync localhost proxy. I can't figure out why, which makes implementation feel risky.

It does however fix the original issue, allowing things like @container queries to work on the back-end. Except for localhost via Browsersync on the back-end, everything works just as I was hoping.

@tcmulder tcmulder moved this from In Progress to Todo in Aquamin Theme Updates Aug 16, 2023
@tcmulder tcmulder moved this from Todo to In Progress in Aquamin Theme Updates Aug 16, 2023
@tcmulder
Copy link
Owner Author

Got this working! It sorta bypasses add_editor_style for now while still using it... check out blocks.php for comments on how that works.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Aquamin Theme Updates Aug 17, 2023
@strarsis
Copy link

New editor styles transformation approach using PostCSS is now merged (many thanks @zaguiini)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants