Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official module #1

Open
bsideup opened this issue Jul 27, 2017 · 8 comments
Open

Official module #1

bsideup opened this issue Jul 27, 2017 · 8 comments

Comments

@bsideup
Copy link

bsideup commented Jul 27, 2017

Hi!

It seems that you extracted and cleaned up the Couchbase module, cool!

Do you want it to be under https://github.com/testcontainers/?
It will help to discover it quicker.

The repo / attributions / decisions will belong to you, so it's just about the place where to put it :)

@tchlyah
Copy link
Owner

tchlyah commented Jul 27, 2017

Hello!

Yes why not, but I was widely inspired by @ldoguin version : Unit and Integration Tests with Couchbase and Docker Containers, maybe I need his confirmation before?

@bsideup
Copy link
Author

bsideup commented Jul 27, 2017

@tchlyah you can join the conversation here:
testcontainers/testcontainers-java#269

I think Laurent is fine with that, but you can ask him there :)

@tchlyah
Copy link
Owner

tchlyah commented Jul 31, 2017

Since I've got @ldoguin confirmation, I see no problem to transfert it to https://github.com/testcontainers repos.

How do we proceed?

@bsideup
Copy link
Author

bsideup commented Jul 31, 2017

@tchlyah
yay! Let's ask @rnorth to create a module and give you the permissions, after that you can transfer the repository to @testcontainers to keep the redirects and stuff

@tchlyah
Copy link
Owner

tchlyah commented Jan 19, 2018

@bsideup, @rnorth
Any news about that?

@guenhter
Copy link

Friendly reminder, that this is still open.

@bsideup
Copy link
Author

bsideup commented Apr 30, 2018

@tchlyah @guenhter we're using a monorepo approach now, you can contribute to the main repo and create a sub-module for the Couchbase integration 👍

@tchlyah
Copy link
Owner

tchlyah commented May 13, 2018

PR done : testcontainers/testcontainers-java#688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants