Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Some code got lost in 2.4.0 rebase with element #286

Open
estellecomment opened this issue Jul 4, 2022 · 3 comments
Open

Some code got lost in 2.4.0 rebase with element #286

estellecomment opened this issue Jul 4, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@estellecomment
Copy link
Contributor

estellecomment commented Jul 4, 2022 •
edited
Loading

There is custom tchap code in InteractiveAuthEntryComponents.js which got lost when we did the bug rebase with element.

See the diff between versions, ctrl+F InteractiveAuthEntryComponents : https://github.com/tchapgouv/matrix-react-sdk/compare/v2.3.7-tchap...2.4.0-tchap

How important is this code, what does it do, should we put it back ?
@estellecomment estellecomment added the bug Something isn't working label Jul 4, 2022
@estellecomment
Copy link
Contributor Author

The code that tchap had added to EmailIdentityAuthEntry ended up in MsisdnAuthEntry after the rebase. We are not using msisdn (phone numbers) so that tchap code is now unreacheable.

@estellecomment estellecomment mentioned this issue Jul 4, 2022
Merged
@jdauphant
Copy link
Contributor

What's concrete problem do we got ?

@estellecomment
Copy link
Contributor Author

No problem that we noticed so far.
It's not clear what this custom code does, and if there's a problem removing it. We need to investigate that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@estellecomment @jdauphant