Enable VoIP 1to1 #993
Merged
Enable VoIP 1to1 #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odelcroi
reviewed
Dec 12, 2023
| R.id.video_call -> vectorFeatures.tchapIsVoipSupported() && | ||
| (state.isCallOptionAvailable() || state.jitsiState.confId == null || state.jitsiState.hasJoined) | ||
| R.id.video_call -> vectorPreferences.developerMode() | ||
| R.id.voice_call -> session.sessionParams.homeServerUrl.contains("agent.dinum.tchap.gouv.fr") && |
There was a problem hiding this comment.
Could it be a util functions? in case more homeserver inside this experimentation and add new "homeserver" based feature flags
There was a problem hiding this comment.
I added the homeserver list in config feature file
yostyle
force-pushed
the
yostyle/voip
branch
from
a6025b9
to
013666e
Compare
yostyle
force-pushed
the
yostyle/voip
branch
from
ad01142
to
37d3ac6
Compare
yostyle
force-pushed
the
yostyle/voip
branch
from
a575918
to
fc788ae
Compare
vector-app/src/androidTest/java/im/vector/app/ui/robot/OnboardingRobot.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
homeServerUrl.contains(it)
Utiliser endsWith plutôt que contains
There was a problem hiding this comment.
R.id.join_conference devrait être systématiquement à False je pense dans cette version. (pas d'autre appel que audio 1-to-1)
yostyle
force-pushed
the
yostyle/voip
branch
from
fc788ae
to
9313cfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
#992
Screenshots / GIFs
Tests
Tested devices
Checklist