Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email address pattern #982

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Fix email address pattern #982

merged 3 commits into from
Oct 19, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Oct 18, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Update email validation in accordance with RFC 5322

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle self-assigned this Oct 18, 2023
@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 37a4661

@yostyle yostyle marked this pull request as ready for review October 18, 2023 21:37
Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the modification in TchapLoginWizard class (login is only authorized by email address) will prevent us to have account with no email address attached (as see in rageShake data) ?

@yostyle yostyle merged commit afd0528 into develop Oct 19, 2023
16 checks passed
@yostyle yostyle deleted the yostyle/fix_email_pattern branch October 19, 2023 08:17
@yostyle
Copy link
Contributor Author

yostyle commented Oct 19, 2023

Does the modification in TchapLoginWizard class (login is only authorized by email address) will prevent us to have account with no email address attached (as see in rageShake data) ?

I will check this but on Tchap Android it's always mandatory to use an email address to sign in in the app.
https://github.com/tchapgouv/tchap-android/blob/develop/vector/src/main/java/im/vector/app/features/onboarding/ftueauth/FtueAuthLoginFragment.kt#L142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants