Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Secure Storage] New wording for beta v1 is not consistent with iOS #870

Open
areox-net opened this issue Mar 1, 2023 · 4 comments
Open
Assignees
Labels

Comments

@areox-net
Copy link
Collaborator

To test a first beta version of the app featuring Secure Storage, we decided to do a light customization of the Element base.

The only two wording changes are:

  • Secure Storage > Sauvegarde automatique des messages
  • Security Key (sometimes Recovery key) > Clé de récupération

These changes need to be implemented across all pages:

  • Security Settings page
  • All the secondary pages/modals when configuring or using the Recovery Key
  • Popup menu when logging out without Secure Storage active: the two options should be "Se deconnecter quand-meme" and "Utiliser la sauvegarde automatique"
@areox-net
Copy link
Collaborator Author

@appndigital Thanks fo rthe update

While testing 2.7.2, I've noticed the following wording and UX issues:

  • this dialog should not appear when Activating the SS from settings. The user doesn't have a choice.
    Screenshot_20230306-144832

  • same is for this dialog when the user wants to enter a key to recover their messages
    Screenshot_20230306-144739

  • When Activating (or Reseting) SS, the following screen should be displayed directly
    Screenshot_20230306-145911

However, some things need to be fixed on this screen:

  • Use the correct wording "Clé de récupération" both on title and paragraph
  • Do not display the "Enregistrez..." button. ANSSI demanded not to provide this option.

@appndigital
Copy link
Contributor

@areox-net
Regarding the first dialog, it seems to me that we have the same dialog on iOS. So aren't we aligned with them?
Moreover on this dialog, there is an info about replacing the existing keys that we may loose if we skipped this dialog

Regarding the second dialog, on this there is two options : use a key or skip. Same thing, if we pass this, then the user could only use key even if he doesn't want it. So can we keep it and only ask for key instead of passphrase and key ?

For the last dialog, I have made the requested change

@areox-net
Copy link
Collaborator Author

@appndigital
Concerning the first dialog. No, we don't have it in iOS or Web. We go directly to the generating a new key.

For the second screen, you are right. We should keep this screen for general verification.
However, the phrase should not mention "pass phrase" since Tchap doesn't have this option. It should just be "Utiliser une clé de récupération".

@areox-net
Copy link
Collaborator Author

@appndigital Since you are at it, we should probably already change "Clé de récupération" to "Code de récupération" as we are doing on iOS and Web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants