Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the icon displayed on the avatar when the room is accessible by link #450

Closed
giomfo opened this issue Feb 24, 2022 · 7 comments
Closed

Comments

@giomfo
Copy link
Contributor

giomfo commented Feb 24, 2022

Currently when a room is accessible by link, a globe is displayed on the avatar (this globe icon comes from Element-Android). This globe is displayed even if the room is not listed in the rooms directory (forums):
image
image

We suggest here to replace this icon with another one more explicit

@areox-net
Copy link
Collaborator

@giomfo could you share the current asset please? Is it a grey icon with a white stroke? I imagine this is only used in the room header, so it only needs to work here, right?

@giomfo
Copy link
Contributor Author

giomfo commented Feb 25, 2022

Question:
image

@areox-net
Copy link
Collaborator

@Florian14 confirmed that the background is not on the asset but added underneath it.
here is a SVG to make a test.

Linkable

@areox-net
Copy link
Collaborator

@giomfo if the test is successful i think we can use this already in Tchap Tatin

@giomfo
Copy link
Contributor Author

giomfo commented Feb 25, 2022

@giomfo if the test is successful i think we can use this already in Tchap Tatin

@areox-net what do you mean by "already"?

@areox-net
Copy link
Collaborator

I mean the v1 of Tchap Tatin. Implement it in the short/mid term without user testing.

@giomfo
Copy link
Contributor Author

giomfo commented Mar 2, 2022

tested on v2.0.2: ok

I will create another issue to discuss about the use of this icon in other screen like rooms list, room settings screen...

@giomfo giomfo closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants