Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On external signout the screen isn't personalized #440

Closed
jdauphant opened this issue Feb 18, 2022 · 4 comments
Closed

On external signout the screen isn't personalized #440

jdauphant opened this issue Feb 18, 2022 · 4 comments
Labels
android bug Something isn't working design enhancement New feature or request question Further information is requested to estimate the task should be estimated before being planned

Comments

@jdauphant
Copy link
Contributor

image

How to reproduce :

  • Change password on an another device
  • The android client is disable
@giomfo giomfo added bug Something isn't working design enhancement New feature or request labels Feb 21, 2022
@giomfo
Copy link
Contributor

giomfo commented Feb 21, 2022

We have first to check the role of this screen before customizing it
This screen is used in Element to handle the soft logout which is not enabled in Tchap.
I think we should not display these options (retry and clear) in Tchap

Related code in RetrofitExtensions.kt

httpCode == HttpURLConnection.HTTP_UNAUTHORIZED && /* 401 */
                        matrixError.code == MatrixError.M_UNKNOWN_TOKEN                                        -> {
                    globalErrorReceiver?.handleGlobalError(GlobalError.InvalidToken(matrixError.isSoftLogout.orFalse()))
                }

@giomfo
Copy link
Contributor

giomfo commented Feb 21, 2022

Step 1: test this screen in Element

@giomfo giomfo added question Further information is requested to estimate the task should be estimated before being planned labels Feb 21, 2022
@Florian14
Copy link
Contributor

I could not reproduce, for each try, I was redirected to the same logout screen:
image

I tried:

  • change the password from the web client, tchap opened in android and logged out by the server
  • change the password from the web client, tchap closed in android and logged out by the server after opening the app
  • remove the android session from the web client, tchap opened in the android session and logged out by the server

Here is the screen for Tchap:
image

@jdauphant
Copy link
Contributor Author

My account is also connected with Element Desktop, this could be a difference ?

@giomfo giomfo closed this as completed Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working design enhancement New feature or request question Further information is requested to estimate the task should be estimated before being planned
Projects
None yet
Development

No branches or pull requests

3 participants