Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the design in the room details screen #168

Closed
4 tasks done
giomfo opened this issue Aug 13, 2021 · 5 comments
Closed
4 tasks done

Adjust the design in the room details screen #168

giomfo opened this issue Aug 13, 2021 · 5 comments
Assignees
Labels

Comments

@giomfo
Copy link
Contributor

giomfo commented Aug 13, 2021

We will use the following screenshot to compare the rendering of a room in the 2 versions of Tchap:
image

I suggest the following changes in TchapV2:
In the room header:
- [ ] display an hexagonal avatar for the room which aren't DM (To be confirmed by the DINUM)
- [ ] display a padlock or the forum icon at the top right corner of the avatar according to the room type (private/forum) (To be confirmed by the DINUM) This point will be handled later in another issue
- [ ] check with the Element Application team to make ellipsis less strict fixed the ellipsis was due to invisible call icons

  • hide the shield at the bottom right corner of the avatar (To be confirmed by the DINUM)

In the room history:
- [ ] display an hexagonal avatar for the room which aren't DM (To be confirmed by the DINUM)

  • hide the option "Ajouter un sujet" when the user is not allowed to edit the room topic (To be fixed in Element-Android)
  • hide the option "Ajouter des personnes" when the user is not allowed to invite new members (To be fixed in Element-Android)
  • hide from the room history the following room state event: m.room.guest_access
    - [ ] check with the DINUM if we should still hide from the room history the following room state event: m.room.join_rules, m.room.join_rules, m.room.history_visibility, m.room.encryption
    - [ ] check with the DINUM if we should hide m.room.name and m.room.topic
@giomfo giomfo added to estimate the task should be estimated before being planned android labels Aug 13, 2021
@giomfo giomfo changed the title [Room History] Adjust the design Adjust the design in the room details screen Aug 13, 2021
@giomfo giomfo removed the blocked label Aug 27, 2021
@giomfo giomfo removed the to estimate the task should be estimated before being planned label Aug 27, 2021
@giomfo
Copy link
Contributor Author

giomfo commented Aug 27, 2021

@Anna-Livia we updated the todo list here with the Element dev team to start the implementation of some points

A discussion with the design team is required to go further on the customisation steps. For example we have to decide which state events must be displayed or not in the room timeline

@giomfo
Copy link
Contributor Author

giomfo commented Sep 3, 2021

some points will be handled by element-hq/element-android#3959

@Anna-Livia
Copy link

A la création du salon, dans l'encart de sécurité, j'aimerais voir les messages suivants :
Si chiffré :

Chiffrement activé 
Les messages de ce salon sont chiffrés de bout en bout. l'historique ne sera pas accessible aux nouveaux participants. Apprenez en plus sur le chiffrement.

Si non chiffré :

Chiffrement désactivé 
Les messages ne sont pas chiffrés. Les nouveaux participants auront accès à l'intégralité de l'historique.Apprenez en plus sur le chiffrement.

@Anna-Livia
Copy link

Les changement de topic, de nom de salon et de mode d'accès doivent être notifié dans l'historique.
Dans les salons privés, on devrait voir les arrivées de nouvelles personnes, quelles soient là par lien ou par invitations

@giomfo giomfo assigned giomfo and unassigned Florian14 and Anna-Livia Oct 8, 2021
@giomfo
Copy link
Contributor Author

giomfo commented Oct 8, 2021

assigned to me in order to create new issues with the pending change requests

@giomfo giomfo closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants