Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable analytics on debug #1101

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Enable analytics on debug #1101

merged 3 commits into from
Aug 14, 2024

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Aug 9, 2024

Enable analytics on debug and fix call duration when event is tracked

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Fix call duration when event is tracked
@yostyle yostyle self-assigned this Aug 9, 2024
Copy link

gitguardian bot commented Aug 9, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13361669 Triggered Generic High Entropy Secret 89a8846 vector-config/src/main/java/im/vector/app/config/Config.kt View secret
13361669 Triggered Generic High Entropy Secret 5a9680b vector-config/src/main/java/im/vector/app/config/Config.kt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Revoke and rotate the secret.

  2. If possible, rewrite git history with git commit --amend and git push --force.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

Generated by 🚫 dangerJS against 5a9680b

@yostyle yostyle marked this pull request as ready for review August 13, 2024 07:56
Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NicolasBuquet NicolasBuquet self-requested a review August 13, 2024 15:16
Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Améliorer le changelog.

changelog.d/1101.bugfix Show resolved Hide resolved
NicolasBuquet

This comment was marked as duplicate.

Copy link
Contributor

@NicolasBuquet NicolasBuquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yostyle yostyle merged commit 4247dea into develop Aug 14, 2024
15 of 18 checks passed
@yostyle yostyle deleted the yostyle/enable_analytics branch August 14, 2024 10:18
yostyle added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants