Enable location sharing #1020
Merged
Enable location sharing #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasBuquet
requested changes
Mar 26, 2024
vector/src/main/java/im/vector/app/core/epoxy/bottomsheet/BottomSheetMessagePreviewItem.kt
Show resolved
Hide resolved
NicolasBuquet
requested changes
Mar 28, 2024
vector/src/main/java/im/vector/app/core/epoxy/bottomsheet/BottomSheetMessagePreviewItem.kt
Outdated
Show resolved
Hide resolved
| @@ -98,10 +100,8 @@ abstract class BottomSheetMessagePreviewItem : VectorEpoxyModel<BottomSheetMessa | |||
| holder.body.isVisible = locationUiData == null | |||
| holder.mapViewContainer.isVisible = locationUiData != null | |||
| locationUiData?.let { safeLocationUiData -> | |||
| GlideApp.with(holder.staticMapImageView) | |||
There was a problem hiding this comment.
Laisser ces lignes en commentaire pour faciliter les futurs rebase ?
There was a problem hiding this comment.
on a l'historique git et le code est déplacé dans map renderer.
vector/src/main/java/im/vector/app/core/epoxy/bottomsheet/BottomSheetMessagePreviewItem.kt
Outdated
Show resolved
Hide resolved
...ava/im/vector/app/features/home/room/detail/timeline/action/MessageActionsEpoxyController.kt
Outdated
Show resolved
Hide resolved
...ava/im/vector/app/features/home/room/detail/timeline/action/MessageActionsEpoxyController.kt
Outdated
Show resolved
Hide resolved
| @@ -75,25 +85,25 @@ abstract class AbsMessageLocationItem<H : AbsMessageLocationItem.Holder>( | |||
| RoundedCorners(dimensionConverter.dpToPx(8)) | |||
| } | |||
| holder.staticMapImageView.updateLayoutParams { | |||
| width = mapWidth | |||
There was a problem hiding this comment.
Laisser les lignes en commentaire et ajouter un Tchap comment
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/AbsMessageLocationItem.kt
Show resolved
Hide resolved
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/AbsMessageLocationItem.kt
Show resolved
Hide resolved
...rc/main/java/im/vector/app/features/home/room/detail/timeline/item/AbsMessageLocationItem.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/location/MapRenderer.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist