Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded color on save button #874

Merged
merged 3 commits into from
Mar 29, 2023

Conversation

jdauphant
Copy link
Contributor

@jdauphant jdauphant commented Mar 4, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Save button background color is hardcoded. Now we use the theming colors instead.

Tests

  • Edit a message and check the save button

Tested devices

  • Physical
  • Emulator
  • OS version(s):

@jdauphant
Copy link
Contributor Author

Also fixed in Element : element-hq/element-android#8208

@tchap-danger-bot
Copy link

Warnings
⚠️

Please add a changelog. See instructions here

⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 9f48308

@tchap-danger-bot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against 31d1e05

@jdauphant
Copy link
Contributor Author

Mergé dans Element

@jdauphant
Copy link
Contributor Author

@NicolasBuquet @appndigital je vous laisse merger les pr si elles sont bonne pour vous

@tchap-danger-bot
Copy link

Warnings
⚠️ Please add a reviewer to your PR.

Generated by 🚫 dangerJS against b2a8d3d

@appndigital appndigital merged commit 4ce9f19 into develop Mar 29, 2023
@appndigital appndigital deleted the patch/remove-hardcoded-color-on-save-button branch March 29, 2023 09:35
@jdauphant jdauphant mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants