Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark modes] Fix contrast of blue color #838

Open
areox-net opened this issue Feb 7, 2023 · 1 comment
Open

[Dark modes] Fix contrast of blue color #838

areox-net opened this issue Feb 7, 2023 · 1 comment

Comments

@areox-net
Copy link
Collaborator

areox-net commented Feb 7, 2023

Your use case

In the current dark modes of the New Layout some issues have merged.
The most urgent one is to fix the contrast of the selected tab in the Home page.

For this we should use the new Tchap Blue color for dark modes:
#3377FF

FIY, we can use the following color all across the app. it should work both as big boxes background and as small text on dark background. So it's not a problem if changing the tab color changes the blue color in other dark mode screens. A more detail ticket about dark modes will follow if needed.

Here is a preview of the expected outcome:

Home page
NewLayout-Accueil-Dark

Conversation
Discussion-Dark

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

@areox-net
Copy link
Collaborator Author

@appndigital I did some more testing in Android after the first dark mode fixes. I noticed a couple of things:

  • When creating a new room the boxes should be dark like the following iOS screen
    IMG_4939

  • in a conversation, the user bubbles should have the same blue color as the rest of the dark mode highlights (#3377FF). Right now they are two different colors as visible in this screenshot
    Screenshot_20230306-161445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant