Enable Danger

[Florian14]

Element-Android v1.4.32 integrates Danger in the CI build process.
Danger is a CI tool automating some common code reviews. It can check that a reviewer has been assigned to a PR, run the code quality checks (Lint, ktlint, Detekt…) and much more by adding plugins to the process.
A bot will then post a comment in the PR in case of failure.

Since Tchap-Android has been rebased on that version, we have to configure Danger to restore some CI steps.
It requires the creation of a new Github account (eg. TchapBot) to check all the Tchap PRs, like Element does.

It does not require adding the bot to the Tchap organization, just the creation of an access token scoped to public_repo as described in the Danger guide.

[giomfo]

@jdauphant is that plan ok for you?

[jdauphant]

We can add Danger support, for access token, it should not be linked to individual account.

[jdauphant]

@pseudonyme21 is on working on similar things on thap-infra repository

[giomfo]

We can add Danger support, for access token, it should not be linked to individual account.

If you use an individual account, it will appear on each comment, like "ElementBot" is the following screenshot:

I would advise to create a specific GH account

[giomfo]

@pseudonyme21 I let you check our suggestion

[jdauphant]

We prefere using Github Apps

[giomfo]

@jdauphant we agree with you according to https://docs.github.com/en/developers/apps/getting-started-with-apps/about-apps. But it seems not possible to use GH apps with Danger : danger/danger-js#1199

How do you want to proceed ? which actions should we plan and who should work on them?

• enable Danger by using GH Apps in order to check if there is issue or not
• ?

@bmarty Did you consider the Github Apps option when you set up Danger for Element-Android? I think we should consider this option for Element, if this was not done yet.

[bmarty]

@bmarty Did you consider the Github Apps option when you set up Danger for Element-Android? I think we should consider this option for Element, if this was not done yet.

No.