Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect network_security_config.xml with fdroid/gplay withpinning flavors #654

Closed
af-anssi opened this issue Jun 29, 2022 · 0 comments
Closed
Assignees
Labels
android bug Something isn't working

Comments

@af-anssi
Copy link

When building any withpinning variant the embedded network_security_config.xml file is not the expected one.

The embedded network_security_config.xml is always the one coming from matrix-sdk-android/src/main/res/xml/network_security_config.xml and not one of vector/src/{fdroid|gplay}/res/xml/network_security_config.xml according to the store dimension.

Using subfolders withpinning in vector/src/fdroid and vector/src/gplay is not working.

After a successful build you can observe the embedded network_security_config.xml in the intermediate folder, for instance in vector/build/intermediates/merged-not-compiled-resources/fdroidTchapWithoutvoipWithpinning/release/xml/ for the variant fdroidTchapWithoutvoipWithpinningRelease.

The official APK published in the Google Play Store also embed the wrong network_security_config.xml.

Using apktool on this APK you can retrieve it under the path res/4u.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants