Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Targets to build #653

Merged
merged 5 commits into from
Jul 27, 2022
Merged

Add New Targets to build #653

merged 5 commits into from
Jul 27, 2022

Conversation

jdauphant
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Add new target to automatically build

Motivation and context

I need dev APKs for testing purpose.
I want to test VoIP to

@@ -52,7 +52,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target: [ GplayBtchapWithoutvoipWithpinning, GplayTchapWithoutvoipWithpinning, FdroidBtchapWithoutvoipWithoutpinning, FdroidTchapWithoutvoipWithoutpinning ]
target: [ GplayBtchapWithoutvoipWithpinning, GplayTchapWithoutvoipWithpinning, FdroidBtchapWithoutvoipWithoutpinning, FdroidTchapWithoutvoipWithoutpinning, GplayDevTchapWithoutvoipWithpinning, FdroidDevTchapWithoutvoipWithoutpinning, GplayBtchapWithvoipWithpinning]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I may need to pull that in debug in fact

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it will be easier to debug if needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do that

@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Unit Test Results

149 tests  ±0   149 ✔️ ±0   23s ⏱️ ±0s
  24 suites ±0       0 💤 ±0 
  24 files   ±0       0 ±0 

Results for commit ae59821. ± Comparison against base commit db9e082.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@Florian14 Florian14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but that will increase the CI duration and the risk of failure while generating the apks (there are 4 APKs for each variant)

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DevTchap should be used to debug instead of Btchap except to test VoIP and pinning.

@@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target: [ GplayBtchapWithoutvoipWithpinning, FdroidBtchapWithoutvoipWithoutpinning ]
target: [ GplayDevTchapWithoutvoipWithoutpinning, FdroidDevTchapWithoutvoipWithoutpinning, GplayBtchapWithvoipWithpinning ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yostyle :

Suggested change
target: [ GplayDevTchapWithoutvoipWithoutpinning, FdroidDevTchapWithoutvoipWithoutpinning, GplayBtchapWithvoipWithpinning ]
target: [ GplayDevTchapWithoutvoipWithoutpinning, FdroidDevTchapWithoutvoipWithoutpinning ]

@yostyle yostyle merged commit 45a5138 into develop Jul 27, 2022
@yostyle yostyle deleted the fix/add-new-targets-to-build branch July 27, 2022 06:55
@yostyle yostyle restored the fix/add-new-targets-to-build branch July 27, 2022 07:47
@yostyle yostyle deleted the fix/add-new-targets-to-build branch July 27, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants