Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Decorators proposal does not have enough tests #3997

Open
nicolo-ribaudo opened this issue Jan 26, 2024 · 2 comments
Open

The Decorators proposal does not have enough tests #3997

nicolo-ribaudo opened this issue Jan 26, 2024 · 2 comments
Labels

Comments

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jan 26, 2024

There are only syntax tests for the decorators proposal, and no behavior tests: https://github.com/search?q=repo%3Atc39%2Ftest262+path%3Adecorator+path%3A%2F%5Etest%5C%2Flanguage%5C%2F%2F&type=code

Babel has been passing all test262 decorators tests for a while, but we still found a lot of bugs in our implementation:

I'm opening this issue because I saw that there is no issue or PR about that proposal, and in our new stages process it probably wouldn't qualify for Stage 3.

EDIT: Something else interesting to test:

@nicolo-ribaudo
Copy link
Member Author

Also, there are some very good tests by @evanw at https://github.com/evanw/decorator-tests

@pzuraq
Copy link

pzuraq commented Feb 21, 2024

I’m planning on working on this in the next few weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants