-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests depends on specific pre-ICU72 format pattern need to be changed #3711
Comments
#3676 updates the non-Temporal tests. |
There are three major changes in ICU 72 impacting ECMA 402 API result
|
See https://icu.unicode.org/download/72 In many formatting patterns, ASCII spaces are replaced with Unicode spaces (e.g., a "thin space"). |
Conclusion: Add this to the agenda in the Test262 maintainers call. |
Notice the following also need to be changed but not covered by #3676 now
|
With #3751 and #3762, those 7 tests should now pass in ICU 72 / CLDR 42. In the future, please check with me and @ptomato before merging PRs like #3676 that match against static strings that vary based on CLDR version. This can be problematic for polyfills and other users of Test262 which have to run in both "old CLDR" and "new CLDR" environments. I'm in the process of making those at least some of those changes more resilient to CLDR version. @ptomato has more ideas (see #3762 (review)) that can improve resilience further. |
I am trying to update the chromium implementation from ICU71 to ICU72 and got the following errors while running test262 test. This is mainly because in ICU72 (due to change in CLDR), the SPACE before AM/PM is changed from ASCII SPACE (U+0020) to THIN SPACE (U+202F)
Just 12 tests, not too bad. but maybe we should change the test to not test against a specific format pattern since CLDR never guarantee those pattern will never change.
The text was updated successfully, but these errors were encountered: