-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change if
keyword to assert
#80
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM if we want to rename if
to assert
. I think we can decide whether we want to do this change during the TC39 meeting, and land if so.
We may want to rename [[Conditions]] to [[Assertions]] and generally rename this proposal (!) to "import assertions", but this can be a later PR.
Sounds good, I'll just leave this un-merged for now. |
9f6331d
to
cdab9d5
Compare
cdab9d5
to
d1c5f89
Compare
As discussed during the July 2020 TC39 meeting, it seems that people are in favor of switching to assert, merging this. |
Should the proposal be renamed as well, to "import assertions"? |
I think so, and @littledan also pointed out that the [[Conditions]] field should probably also be renamed. I filed #87 and I will make these changes if there are no objections. |
Change
if
keyword toassert
in README and spec.Add
[no LineTerminator here]
prior toAssertClause
.