-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domenic Feedback #5
Comments
I want to amend this a bit. I think a crucial part of getting stage 2 (i.e., commitment that this should be in the language) is signs that this method gets high adoption, comparable to existing libraries, and that TC39 isn't pushing through something that the community is uninterested in. So I think it should be released during stage 1, and high adoption for the library will be a stage 2 prerequisite. |
I would like to have a polyfill available before next meeting, but high adoption seems extremely high bar for reaching stage 2. Are there other examples where that was a requirement for stage 2? |
Observables. |
thanks! And since both proposals have similarities, I think it is fair. |
As we discussed in TC39, I don't think it's a reasonable requirement to ask that the adoption be the same as existing libraries. We don't seem to be asking for this in other ongoing standard library efforts:
(Observables never advanced to Stage 2, but there were multiple issues other than "lack of ecosystem adoption" that held it back.) It may be better to wait a bit to widely popularize a library, so we still have latitude to change it as we continue to get feedback. |
I think we may be talking past each other.
I am worried about emitter introducing a new unproven pattern and API shape to the ecosystem, with no commitment from ecosystem members to base themselves on top of it. If we can get ecosystem acceptance at the same level as KV storage's API, or commitment from popular event libraries (like RxJS or the DOM) to base themselves on emitter, then we're in a better place to consider this as something to be "eventually included in the standard". |
I think the idea here is to do something broadly similar--that Emitter would be designed to meet many of the usage patterns of Observable, without being exactly the same API. This is analogous (but maybe greater in degree?) to how kv-storage doesn't use the same method names as localForage, or how TC39 Promises have some semantic differences from jQuery Promises. I agree that it will be important to work with the existing Observable library maintainers, so I'm encouraged that this conversation has already begun in #7 . |
I second that high adoption of a library is not a reasonable or a desirable bar here as a stage 2 entry criterion. The approach here is as @littledan lays out: this is a synthesis of prior art in other languages, as well as existing JS libraries, proposals, and common feedback about them. Collaboration with existing event library authors and other folks in the ecosystem is definitely reasonable. |
Very productive meeting with @domenic and lots of great feedback.
The text was updated successfully, but these errors were encountered: