Matteo Feedback

[pemrouz]

Very productive meeting with @mcollina and lots of great feedback.

• Event arguments are variadic in Node, which is regrettable. Precedent with once function Matteo added is that single argument would always be an array. We should probably do the same.
• Add emitter.next(42) to new Emitter section so more standalone
• Use non-array examples, maybe async iterator (@j03m also mentioned this)
• Change wording about revealing constructor pattern, interceptor seems clearer
• run vs evaluate may be confusing. From the EventEmitter perspective, can be sync, but usually async (@rpamely previously suggested we may be able to combine. run would return the value if it's done, or a promise for the value if not. Useful since we remove one function and concept without losing features/use cases).
• Add EventEmitter + Node Streams to benchmarks
• Error-handling cases: What happens when you next a value into a resolved/rejected Emitter? We handle this, but add and walkthrough these scenarios. There was some memory leaks related to this in Node.
• @mcollina will play around with this internally in Node after June meeting, could be behind a flag. We'll work more closely to incorporate any feedback before the subsequent meeting.
• run is very nice: trying to compose async iterators can be very confusing, the way you have to write the functions, etc. This inversion of control, running a source into something else, makes things more composable and easy to work with, trivial to factor out into modules)
• Async iterable as source/sink is also very nice, need to add more examples (e.g. reading from a file, reducing into a file perhaps)
• Share and socialise at the Node JS collaborator submit.