Use Abstract Relational Comparison to compare string values in SortCompare #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bugzilla#4330 indicates that some browsers use a different comparison semantics. Which browsers? Do they still? /cc @allenwb |
|
The bugzilla issue was filed in response to https://twitter.com/tobie/status/590525140091437056, but I couldn't find any difference in the default comparator implementation when comparing V8 3.28.73 and 4.1.0.14. Maybe something else changed in 4.1.0.14 which led to an observable difference in Array.prototype.sort... |
|
Well in any case this seems good and is in line with implementations as far as I can tell. |
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.ecmascript.org/show_bug.cgi?id=4330